Improving your code reviews with TAGs

Eduardo Sanches Bocato
1 min readJun 17, 2020

Introduction

It's very common to end up having to leave some change to your future self, when deadlines are tight and we end up creating technical debits.
To make it easier for us to decide which change needs to be applied right away, my team and I decided to create a tagging system for that.

Tags

[NICE TO HAVE]

Means that something can be changed, but it’s not that crucial to do it right away.

[SUGGESTION]

Means that an improvement can be made, and we strongly suggest it, but if it’s justified and not implemented, the PR will still be approved.

[CHANGE REQUEST]

Means that something needs to be changed, otherwise the PR won’t be approved.

[CLARIFICATION]

Means that the reviewer needs more information about the implementation.

Conclusion

Doing that, we can speed up our approval process when needed, get a better definition of what can be dealt in a future oportunity and make our Pull Request more meaningful.

--

--

Eduardo Sanches Bocato

iOS Engineer, AI enthusiast, Crossfit/Gymnastics. Currently working as iOS Lead @adidas